Skip to content

Abort if check nightly options failed on stable #115713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2023
Merged

Abort if check nightly options failed on stable #115713

merged 1 commit into from
Sep 10, 2023

Conversation

chenyukang
Copy link
Member

Fixes #115680
Also, if there are multiple unstable options passing on stable compiler, printing multiple same note and help seems noisy.

@rustbot
Copy link
Collaborator

rustbot commented Sep 9, 2023

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 9, 2023
@compiler-errors
Copy link
Member

r=me with nit

@chenyukang chenyukang force-pushed the yukang-fix-115680-rustdoc-arg-check branch from e9d4b12 to 12888d2 Compare September 10, 2023 02:02
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 10, 2023

📌 Commit 12888d2 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2023
@bors
Copy link
Collaborator

bors commented Sep 10, 2023

⌛ Testing commit 12888d2 with merge dda95c1...

@bors
Copy link
Collaborator

bors commented Sep 10, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing dda95c1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 10, 2023
@bors bors merged commit dda95c1 into rust-lang:master Sep 10, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 10, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (dda95c1): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.1% [-1.1%, -1.1%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.4% [-1.4%, -1.4%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.3% [-1.6%, -1.0%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.3% [-1.6%, -1.0%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 629.667s -> 628.712s (-0.15%)
Artifact size: 317.82 MiB -> 317.95 MiB (0.04%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.

stable rustdoc accepts unstable nightly flags
5 participants
@chenyukang @rustbot @compiler-errors @bors @rust-timer